-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[liqoctl] include network init in connect #2918
Merged
adamjensenbot
merged 1 commit into
liqotech:master
from
claudiolor:clo/remote-liqoctl-init
Feb 10, 2025
Merged
[liqoctl] include network init in connect #2918
adamjensenbot
merged 1 commit into
liqotech:master
from
claudiolor:clo/remote-liqoctl-init
Feb 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
1b09a13
to
7e83c53
Compare
31ba8f8
to
28f79dd
Compare
fra98
approved these changes
Feb 6, 2025
35a89d5
to
6535d5b
Compare
/test |
/rebase test=true |
This patch removes the `liqoctl network init` command, including its functionalities into `connect`. This simplifies usage and removes a command which is really unlikely used alone.
6535d5b
to
05e1dcb
Compare
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
liqoctl network init
command, including its functionalities intoconnect
. This simplifies usage and removes a command which is really unlikely used alone.